Types of changes

Done by pairing with @claremacrae

Changes visible to users:

• Bug fix (prefix: fix - non-breaking change which fixes an issue)
  • Issue/discussion: Unreported issue found in testing the implementation of Add post-Search Filter to results view #3693

Description

Prior to this PR, when the Toolbar input 'Filter by description' was used, as soon as the search was redrawn the filter was lost, and all matching tasks were shown.

This meant that if you wanted to narrow down a Tasks code block to find-and-edit several tasks, you had to re-enter the search term after every edit.

And that got very old, very quickly!

Now, any filter string in the Toolbar is now retained.

Note that any cursor position is, however, not retained. We don't think that is a high priority to fix.

Motivation and Context

This is a critical component of making #3693 releasable...

How has this been tested?

• Unit test + manual test

Checklist

• My code follows the code style of this project and passes yarn run lint.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• My change has adequate Unit Test coverage.
  • The filter string being kept in the search box between task rerenders is tested manually

Terms

• My contribution follows this project's contributing guide
• I agree to follow this project's Code of Conduct